This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
accounts-cluster-bench, close all accounts in a sliding window #17993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17993 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 435 435
Lines 121572 121572
=========================================
- Hits 100466 100443 -23
- Misses 21106 21129 +23 |
accounts-cluster-bench/src/main.rs
Outdated
| .long("close-frequency") | ||
| .takes_value(true) | ||
| .value_name("BYTES") | ||
| .help( | ||
| "Send close transactions after this many accounts created. \ | ||
| "Every `n` batches, create a batch of close transactions for | ||
| the first batch of accounts created. |
There was a problem hiding this comment.
Suggested change
| the first batch of accounts created. | |
| the earliest remaining batch of accounts created. |
accounts-cluster-bench/src/main.rs
Outdated
Comment on lines
587
to
589
| Note: a `close-frequency` value near or below `batch-size` \ | ||
| may result in transaction-simulation errors, as the close \ | ||
| transactions will be submitted before the corresponding \ |
There was a problem hiding this comment.
Remove this part of the comment?
There was a problem hiding this comment.
Updated the comment!
accounts-cluster-bench/src/main.rs
Outdated
Comment on lines
480
to
482
| let expected_closed = (total_accounts_created as u64 | ||
| / (close_nth_batch * batch_size as u64)) | ||
| * batch_size as u64; |
There was a problem hiding this comment.
Suggested change
| let expected_closed = (total_accounts_created as u64 | |
| / (close_nth_batch * batch_size as u64)) | |
| * batch_size as u64; | |
| let num_batches_to_close = total_accounts_created as u64 | |
| / (close_nth_batch * batch_size as u64); | |
| let expected_closed = num_batches_to_close * batch_size as u64; |
Total nit, but just makes it a little more clear why the batch_sizes don't cancel out
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2021
(cherry picked from commit ed18add)
mergify bot
added a commit
that referenced
this pull request
Jun 16, 2021
… (#18026) (cherry picked from commit ed18add) Co-authored-by: carllin <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Can't simulate cleaning of zero-lamport accounts in accounts-cluster-bench unless a sliding window of
created accounts are all eventually zeroed
Summary of Changes
Support closing all accounts in a sliding window
Fixes #