This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
fix loader instruction checker #18047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
force-pushed
the
fix-is-instruction
branch
from
28ac7b7 to
cdc4e9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #18047 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.1%
=========================================
Files 434 434
Lines 121192 121194 +2
=========================================
- Hits 99815 99794 -21
- Misses 21377 21400 +23 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2021
(cherry picked from commit d18e02e)
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2021
(cherry picked from commit d18e02e)
mergify bot
added a commit
that referenced
this pull request
Jun 18, 2021
(cherry picked from commit d18e02e) Co-authored-by: Jack May <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jun 18, 2021
(cherry picked from commit d18e02e) Co-authored-by: Jack May <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Loader instruction checker doesn't like empty slices
Summary of Changes
Make them friends
Fixes #