This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Removed unused purged_slots in purge_older_root_entries #18102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijunwangs
force-pushed
the
remove_unused_hashset_in_purge
branch
from
b402c7e to
23052bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #18102 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.1%
=========================================
Files 434 434
Lines 120963 120961 -2
=========================================
- Hits 99663 99637 -26
- Misses 21300 21324 +24 |
carllin
approved these changes
Jun 22, 2021
|
Removed unused purged_slots in purge_older_root_entries |
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
Removed unused purged_slots in purge_older_root_entries (cherry picked from commit ccf6b21)
mvines
pushed a commit
that referenced
this pull request
Jul 2, 2021
Removed unused purged_slots in purge_older_root_entries (cherry picked from commit ccf6b21)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
purged_slots hashset is declared and entry added locally and not read.
Summary of Changes
Removed unused purged_slots in purge_older_root_entries
Fixes #