This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Reject transactions with extra signatures #18306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
reviewed
Jun 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #18306 +/- ##
=========================================
Coverage ? 82.3%
=========================================
Files ? 435
Lines ? 121464
Branches ? 0
=========================================
Hits ? 100033
Misses ? 21431
Partials ? 0 |
jstarry
force-pushed
the
prohibit-extra-sigs
branch
from
02297cc to
b497181
Compare
jstarry
added
v1.7
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
jstarry
force-pushed
the
prohibit-extra-sigs
branch
from
9e1e32f to
d2531d2
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2021
* Reject transactions with extra signatures * fix tests * fix check * fix check * tx method * fix checks (cherry picked from commit d5961e9)
mergify bot
added a commit
that referenced
this pull request
Jul 1, 2021
* Reject transactions with extra signatures * fix tests * fix check * fix check * tx method * fix checks (cherry picked from commit d5961e9) Co-authored-by: Justin Starry <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Transactions with extra signatures can be replayed
Summary of Changes
Fixes #18303