This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Bump prost, prost-types, and tonic #18537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvines , could you please see if you see anything concerning with the |
CriesofCarrots
force-pushed
the
bump-prost-types
branch
from
1f4ddd0 to
325f82a
Compare
CriesofCarrots
force-pushed
the
bump-prost-types
branch
from
325f82a to
f50e21a
Compare
mvines
approved these changes
Jul 9, 2021
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #18537 +/- ##
=========================================
Coverage ? 82.6%
=========================================
Files ? 442
Lines ? 123737
Branches ? 0
=========================================
Hits ? 102317
Misses ? 21420
Partials ? 0 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
* Bump prost+tonic and accommodate generated service changes * Unignore advisory * Fixup .proto error list (cherry picked from commit 761de8b) # Conflicts: # Cargo.lock # storage-bigtable/Cargo.toml # storage-proto/Cargo.toml
mergify bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
* Bump prost+tonic and accommodate generated service changes * Unignore advisory * Fixup .proto error list (cherry picked from commit 761de8b) # Conflicts: # Cargo.lock # storage-bigtable/Cargo.toml # storage-proto/Cargo.toml
mergify bot
added a commit
that referenced
this pull request
Jul 9, 2021
* Bump prost, prost-types, and tonic (#18537) * Bump prost+tonic and accommodate generated service changes * Unignore advisory * Fixup .proto error list (cherry picked from commit 761de8b) # Conflicts: # Cargo.lock # storage-bigtable/Cargo.toml # storage-proto/Cargo.toml * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jul 9, 2021
* Bump prost, prost-types, and tonic (#18537) * Bump prost+tonic and accommodate generated service changes * Unignore advisory * Fixup .proto error list (cherry picked from commit 761de8b) # Conflicts: # Cargo.lock # storage-bigtable/Cargo.toml # storage-proto/Cargo.toml * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
prost-typessecurity advisory is ignored due to googleapi build errors -> need to bump tonic_build and regenerate rust googleapis in unison.Summary of Changes
Closes #18541
Closes #18545