This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
removes id from push_lowest_slot args #18645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
push_lowest_slot cannot sign the new crds-value unless the id (pubkey) argument passed-in is the same pubkey as in ClusterInfo::keypair(), in which case the id argument is redundant: https://github.com/solana-labs/solana/blob/bb41cf346/gossip/src/cluster_info.rs#L824-L845 Additionally, the lookup is done with self.id(), but insert is done with the id argument, which is logically a bug.
sakridge
approved these changes
Jul 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #18645 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 436 436
Lines 123482 123476 -6
=======================================
+ Hits 102144 102145 +1
+ Misses 21338 21331 -7 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
push_lowest_slot cannot sign the new crds-value unless the id (pubkey) argument passed-in is the same pubkey as in ClusterInfo::keypair(), in which case the id argument is redundant: https://github.com/solana-labs/solana/blob/bb41cf346/gossip/src/cluster_info.rs#L824-L845 Additionally, the lookup is done with self.id(), but insert is done with the id argument, which is logically a bug. (cherry picked from commit c90af3c) # Conflicts: # gossip/src/cluster_info.rs
CriesofCarrots
pushed a commit
that referenced
this pull request
Jul 16, 2021
push_lowest_slot cannot sign the new crds-value unless the id (pubkey) argument passed-in is the same pubkey as in ClusterInfo::keypair(), in which case the id argument is redundant: https://github.com/solana-labs/solana/blob/bb41cf346/gossip/src/cluster_info.rs#L824-L845 Additionally, the lookup is done with self.id(), but insert is done with the id argument, which is logically a bug. (cherry picked from commit c90af3c) # Conflicts: # gossip/src/cluster_info.rs
mergify bot
added a commit
that referenced
this pull request
Jul 16, 2021
* removes id from push_lowest_slot args (#18645) push_lowest_slot cannot sign the new crds-value unless the id (pubkey) argument passed-in is the same pubkey as in ClusterInfo::keypair(), in which case the id argument is redundant: https://github.com/solana-labs/solana/blob/bb41cf346/gossip/src/cluster_info.rs#L824-L845 Additionally, the lookup is done with self.id(), but insert is done with the id argument, which is logically a bug. (cherry picked from commit c90af3c) # Conflicts: # gossip/src/cluster_info.rs * removes backport merge conflicts Co-authored-by: behzad nouri <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
push_lowest_slotcannot sign the new crds-value unless the id (pubkey)argument passed-in is the same pubkey as in
ClusterInfo::keypair(), inwhich case the id argument is redundant:
https://github.com/solana-labs/solana/blob/bb41cf346/gossip/src/cluster_info.rs#L824-L845
Additionally, the lookup is done with
self.id(), but insert is done withthe id argument, which is logically a bug.
Summary of Changes
id: Pubkeyfrompush_lowest_slotarguments, in favor of usingClusterInfo::id.