Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Write helper for multithread update #18808

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

sakridge
Copy link
Contributor

Problem

Common pattern of using at atomic to report stats a single time for multiple thread workers.

Summary of Changes

Helper class reduces boilerplate for this pattern and makes it easier to update to best-practices.

Fixes #

@sakridge sakridge force-pushed the atomic-interval branch 8 times, most recently from e50fe14 to 94079cf Compare July 22, 2021 16:14
@sakridge sakridge requested a review from ryoqun July 22, 2021 16:16
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #18808 (ee01a0a) into master (611af87) will decrease coverage by 0.0%.
The diff coverage is 88.7%.

@@            Coverage Diff            @@
##           master   #18808     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         443      443             
  Lines      126082   126316    +234     
=========================================
+ Hits       104499   104636    +137     
- Misses      21583    21680     +97     

Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sakridge sakridge merged commit 84e7831 into solana-labs:master Jul 29, 2021
@sakridge sakridge deleted the atomic-interval branch July 29, 2021 01:16
@sakridge sakridge added the v1.7 label Aug 18, 2021
mergify bot pushed a commit that referenced this pull request Aug 18, 2021
(cherry picked from commit 84e7831)

# Conflicts:
#	core/benches/cluster_info.rs
#	core/src/broadcast_stage.rs
#	core/src/broadcast_stage/broadcast_duplicates_run.rs
#	core/src/broadcast_stage/standard_broadcast_run.rs
sakridge added a commit that referenced this pull request Aug 18, 2021
sakridge added a commit that referenced this pull request Sep 2, 2021
mergify bot added a commit that referenced this pull request Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants