This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rpc: Fix erroneous default start_slot in getBlocks #18948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18948 +/- ##
=========================================
- Coverage 82.7% 82.6% -0.1%
=========================================
Files 448 448
Lines 127172 127173 +1
=========================================
- Hits 105186 105100 -86
- Misses 21986 22073 +87 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 578f2aa)
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 578f2aa)
CriesofCarrots
added a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 578f2aa)
mergify bot
added a commit
that referenced
this pull request
Jul 29, 2021
(cherry picked from commit 578f2aa) Co-authored-by: Tyera Eulberg <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jul 29, 2021
(cherry picked from commit 578f2aa) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
getBlockshas the same bug thatgetBlocksWithLimitdid 🤕 039e4d8Summary of Changes
If
getBlocksdoesn't find any finalized blocks in range, usestart_slotto filter confirmed blocks instead of defaultFixes #18946