This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
add validator option --accounts-db-skip-shrink #19028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
skip_shrink
branch
4 times, most recently
from
e70a5bf to
d068b38
Compare
jeffwashington
force-pushed
the
skip_shrink
branch
from
d068b38 to
b5b3fac
Compare
|
verified this disables shrink on a validator |
CriesofCarrots
previously approved these changes
Aug 4, 2021
validator/src/main.rs
Outdated
| Arg::with_name("accounts_db_skip_shrink") | ||
| .long("accounts-db-skip-shrink") | ||
| .help("Enables faster starting of validators by skipping shrink. \ | ||
| This option if for use during testing."), |
There was a problem hiding this comment.
Suggested change
| This option if for use during testing."), | |
| This option is for use during testing."), |
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
|
Any plans to backport this one? If not, can we add a hidden stub flag on v1.7 for compatibility |
I have no objections to back porting it. It should not add risk if I did it right ;-) |
Codecov Report
@@ Coverage Diff @@
## master #19028 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 449 449
Lines 127997 128002 +5
=========================================
+ Hits 105993 105994 +1
- Misses 22004 22008 +4 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
* add validator option --accounts-db-skip-shrink * typo (cherry picked from commit 3280ae3) # Conflicts: # core/tests/snapshots.rs # ledger/src/bank_forks_utils.rs # ledger/src/blockstore_processor.rs # replica-node/src/replica_node.rs # runtime/src/snapshot_utils.rs
CriesofCarrots
pushed a commit
that referenced
this pull request
Aug 10, 2021
* add validator option --accounts-db-skip-shrink * typo (cherry picked from commit 3280ae3) # Conflicts: # core/tests/snapshots.rs # ledger/src/bank_forks_utils.rs # ledger/src/blockstore_processor.rs # replica-node/src/replica_node.rs # runtime/src/snapshot_utils.rs
CriesofCarrots
pushed a commit
that referenced
this pull request
Aug 10, 2021
) * add validator option --accounts-db-skip-shrink (#19028) * add validator option --accounts-db-skip-shrink * typo (cherry picked from commit 3280ae3) # Conflicts: # core/tests/snapshots.rs # ledger/src/bank_forks_utils.rs # ledger/src/blockstore_processor.rs # replica-node/src/replica_node.rs # runtime/src/snapshot_utils.rs * Fix conflicts Co-authored-by: Jeff Washington (jwash) <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When restarting validators with large snapshots, shrink can take hours. This option is useful to more quickly get to other troublesome parts of validator startup while debugging the system.
Summary of Changes
Fixes #