This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Deprecate FeeCalculator returning APIs #19120
Merged
jackcmay
merged 3 commits into
solana-labs:master
from
jackcmay:deprecate-feecalcalulator-returning-apis
Aug 13, 2021
Merged
Deprecate FeeCalculator returning APIs #19120
jackcmay
merged 3 commits into
solana-labs:master
from
jackcmay:deprecate-feecalcalulator-returning-apis
Aug 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
274ec8e
to
04032c8
Compare
a8f171f
to
8b66dd4
Compare
f38c361
to
5818a70
Compare
@t-nelson Would you take a look at least at the nonce/offline signing related stuff? |
Codecov Report
@@ Coverage Diff @@
## master #19120 +/- ##
=========================================
- Coverage 82.9% 82.8% -0.1%
=========================================
Files 455 455
Lines 129154 129413 +259
=========================================
+ Hits 107159 107278 +119
- Misses 21995 22135 +140 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one consideration about the various get_fee_for_transaction
methods that take a Message...
Otherwise, nitty nits. (Btw, the nonce stuff I only skimmed, since Trent will be looking at that closely)
t-nelson
reviewed
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nonce/offline stuff looks great. Just one comment from me beyond Tyera's notes
1fd73e7
to
8d5a44c
Compare
CriesofCarrots
approved these changes
Aug 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FeeCalculator
is directly exposed via external APIs limiting the evolution of how Solana calculates fees.Summary of Changes
FeeCalculator
Message
These changes do not change how Solana calculates fees, but instead encapsulates the fee calculations to the bank so that they may evolve over time.
Outstanding work:
Fixes #