-
Notifications
You must be signed in to change notification settings - Fork 4.7k
framework to preserve optimistic_slot in blockstore #25362
framework to preserve optimistic_slot in blockstore #25362
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25362 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 616 616
Lines 169469 169489 +20
=========================================
+ Hits 139161 139164 +3
- Misses 30308 30325 +17 |
Thanks for breaking this out into its' own PR - should make backporting much easier! One thing - I think we should include the |
Also - I assume this will be end up being backported to |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for splitting the PRs to allow back-porting.
Left one comment that might be a potential follow-up in the next PR.
(cherry picked from commit 8caf0aa) # Conflicts: # ledger/src/blockstore.rs # ledger/src/blockstore_db.rs # ledger/src/blockstore_metrics.rs
…#26131) * framework to preserve optimistic_slot in blockstore (#25362) (cherry picked from commit 8caf0aa) # Conflicts: # ledger/src/blockstore.rs # ledger/src/blockstore_db.rs # ledger/src/blockstore_metrics.rs * merge * merge Co-authored-by: Jeff Biseda <[email protected]>
…labs#25362) (solana-labs#26131) * framework to preserve optimistic_slot in blockstore (solana-labs#25362) (cherry picked from commit 8caf0aa) * merge * merge Co-authored-by: Jeff Biseda <[email protected]>
…labs#25362) (solana-labs#26131) * framework to preserve optimistic_slot in blockstore (solana-labs#25362) (cherry picked from commit 8caf0aa) * merge * merge Co-authored-by: Jeff Biseda <[email protected]>
Problem
Latest
optimistic_slot
value is needed when coordinating a restart. This value can be lost if logging is disabled or logs are deleted.Summary of Changes
blockstore column family changes to support storing optimistic slot information.
See #25311 for follow-on changes.
For release notes:
This change introduces a new rocksdb column family:
optimistic_slots
. If the validator software is subsequently downgraded the validator will fail to start with the following error:'Failed to open ledger database: RocksDb(Error { message: "Invalid argument: Column families not opened: optimistic_slots" })'
This can be remedied by dropping the
optimistic_slots
column family. Use theldb
tool provided with the rocksdb distribution.Confirm that the database contains the
optimistic_slots
column family:ldb --db=<full_path_to_db_directory> list_column_families
Drop the
optimistic_slots
column family:ldb --db=<full_path_to_db_directory> drop_column_family optimistic_slots
Fixes #