Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Remove bank test_max_accounts_data_size_exceeded() #26772

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 0 additions & 56 deletions runtime/src/bank.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17954,62 +17954,6 @@ pub(crate) mod tests {
);
}

/// Test exceeding the max accounts data size by creating accounts in a loop
#[test]
fn test_max_accounts_data_size_exceeded() {
const NUM_ACCOUNTS: u64 = 20;
const ACCOUNT_SIZE: u64 = MAX_PERMITTED_DATA_LENGTH / (NUM_ACCOUNTS + 1);
const REMAINING_ACCOUNTS_DATA_SIZE: u64 = NUM_ACCOUNTS * ACCOUNT_SIZE;

let (genesis_config, mint_keypair) = create_genesis_config(1_000_000_000_000);
let mut bank = Bank::new_for_tests(&genesis_config);
bank.activate_feature(&feature_set::cap_accounts_data_len::id());
bank.accounts_data_size_initial = bank.accounts_data_size_limit()
- REMAINING_ACCOUNTS_DATA_SIZE
- bank.load_accounts_data_size_delta() as u64;

let mut i = 0;
let result = loop {
let txn = system_transaction::create_account(
&mint_keypair,
&Keypair::new(),
bank.last_blockhash(),
genesis_config
.rent
.minimum_balance(ACCOUNT_SIZE.try_into().unwrap()),
ACCOUNT_SIZE,
&solana_sdk::system_program::id(),
);

let accounts_data_size_before = bank.load_accounts_data_size();
let result = bank.process_transaction(&txn);
let accounts_data_size_after = bank.load_accounts_data_size();
assert!(accounts_data_size_after <= bank.accounts_data_size_limit());
if result.is_err() {
assert_eq!(i, NUM_ACCOUNTS);
break result;
}

assert_eq!(
accounts_data_size_after - accounts_data_size_before,
ACCOUNT_SIZE,
);
assert!(
i <= NUM_ACCOUNTS,
"test must complete within bounded limits"
);
i += 1;
};

assert!(matches!(
result,
Err(TransactionError::InstructionError(
_,
solana_sdk::instruction::InstructionError::MaxAccountsDataSizeExceeded,
))
));
}

/// Test processing a good transaction correctly modifies the accounts data size
#[test]
fn test_accounts_data_size_with_good_transaction() {
Expand Down