Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Do not check accounts data size in InvokeContext #26773

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jul 25, 2022

Problem

To fix #26439, checking the total accounts data size is moving to ReplayStage. Checking if instructions exceed the accounts data size limit is no longer needed.

See #26744 for full code.

Summary of Changes

  • Remove checking if instructions exceed the accounts data size limit.
  • Remove maximum from AccountsDataMeter
    • this also removes remaining(), adjust_delta(), and maximum(), plus their uses

Feature Gate Issue: modifies #24135

@brooksprumo brooksprumo force-pushed the accounts-data-len/accounts-data-meter branch from 0c4e3ce to e34fc47 Compare August 5, 2022 14:03
@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label Aug 5, 2022
@brooksprumo brooksprumo marked this pull request as ready for review August 5, 2022 15:30
@brooksprumo brooksprumo requested review from Lichtso and jstarry August 5, 2022 16:13
@brooksprumo brooksprumo requested a review from jstarry August 5, 2022 18:41
@brooksprumo brooksprumo merged commit dc9a923 into solana-labs:master Aug 8, 2022
@brooksprumo brooksprumo deleted the accounts-data-len/accounts-data-meter branch August 8, 2022 15:05
apfitzge pushed a commit to apfitzge/agave that referenced this pull request Aug 9, 2022
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforcing max account data cap may introduce indeterminism
2 participants