This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: Use dynamic memory layout for TransactionContext::instruction_trace
#27587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/consecutive_memory_for_instruction_trace
branch
8 times, most recently
from
98ff1c8 to
d8983a4
Compare
Lichtso
force-pushed
the
refactor/consecutive_memory_for_instruction_trace
branch
7 times, most recently
from
b775f96 to
1bc1ab4
Compare
Lichtso
force-pushed
the
refactor/consecutive_memory_for_instruction_trace
branch
from
1bc1ab4 to
d2d0d20
Compare
Lichtso
force-pushed
the
refactor/consecutive_memory_for_instruction_trace
branch
2 times, most recently
from
6985523 to
f7b2536
Compare
Lichtso
force-pushed
the
refactor/consecutive_memory_for_instruction_trace
branch
from
f7b2536 to
0c60d4b
Compare
Lichtso
force-pushed
the
refactor/consecutive_memory_for_instruction_trace
branch
from
0c60d4b to
aa17201
Compare
|
@alessandrod and I decided to use BTF in RBPF instead to compile in the memory layout at relocation time instead of looking it up at runtime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ABIv2 design requires all shared (between SBF programs and the runtime) properties to be flattened and accessible form the
TransactionContext.Summary of Changes
Adds
DynamicLayoutArray. Collapses two nesting levels: Inlines allVecs ofInstructionContextand the struct itself intoTransactionContext::instruction_trace.