remove data size check from cost model #30205
Conversation
tao-stones
force-pushed
the
refactor-remove-data-size-from-cost-model
branch
from
4c425c1 to
fdee174
Compare
| @@ -1598,15 +1598,7 @@ impl Bank { | |||
| .map(|drop_callback| drop_callback.clone_box()), | |||
| )), | |||
| freeze_started: AtomicBool::new(false), | |||
| cost_tracker: RwLock::new(CostTracker::new_with_account_data_size_limit( | |||
| feature_set | |||
| .is_active(&feature_set::cap_accounts_data_len::id()) | |||
There was a problem hiding this comment.
this feature is not scheduled for activation according to #24135
|
|
||
| if self | ||
| .feature_set | ||
| .is_active(&feature_set::cap_accounts_data_len::id()) |
There was a problem hiding this comment.
same as above. For context, the follow up tasks for #29743 (and this PR) is to introduce a compute_budget instruction to request account data size limit per tx, and charge a fee to economically incentive better space utilization.
This is a valid point. I checked metric (#30204 (comment)) to confirm that this check hasn't kicked in past days. It is certainly safer to hold it till above mentioned features are activated, but IMO the benefit doesn't justify the delay (of #30035). But in any case, it'd be good to have more inputs, other than @mvines , who can we victimize? |
|
Ya, I'm not informed enough on this part of the code to give a good review here unfortunately. |
github-actions
bot
added
the
stale
Problem
code outlived its purpose, described in issue #30204
Summary of Changes
Fixes #30204