This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix - Revert and feature gate incorrect error message in BPF loader #30748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
added
bug
Lichtso
force-pushed
the
fix/revert_and_feature_gate_incorrect_error_message
branch
from
891d8f7 to
955686a
Compare
Codecov Report
@@ Coverage Diff @@
## master #30748 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 726 726
Lines 203490 203536 +46
=========================================
- Hits 165599 165594 -5
- Misses 37891 37942 +51 |
Lichtso
force-pushed
the
fix/revert_and_feature_gate_incorrect_error_message
branch
from
955686a to
3933f83
Compare
pgarg66
reviewed
Mar 17, 2023
pgarg66
previously approved these changes
Mar 17, 2023
pgarg66
approved these changes
Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#30614 removed an incorrect error condition partially and without a feature gate.
Summary of Changes
Add a feature gate
remove_bpf_loader_incorrect_program_idwhich temporarily reverts the behavior back to what it was before.Feature Gate Issue: #30747