This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Makes snapshot_utils aware of Incremental Accounts Hash #30804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
added
work in progress
brooksprumo
added
CI
Codecov Report
@@ Coverage Diff @@
## master #30804 +/- ##
========================================
Coverage 81.4% 81.4%
========================================
Files 725 725
Lines 203596 203721 +125
========================================
+ Hits 165833 166030 +197
+ Misses 37763 37691 -72 |
brooksprumo
added
the
feature-gate
brooksprumo
force-pushed
the
iah/snapshot_utils
branch
from
5565c62 to
bc2da66
Compare
brooksprumo
added
the
automerge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
snapshot_utilsdoes not know about Incremental Accounts Hash, so the helps functions that create snapshots, and the functions that reconstruct a bank from snapshot archives cannot handle IAH.Summary of Changes
snapshot_utilscan now to do bank-to-snapshot-archive and bank-from-snapshot-archive for incremental snapshots with IAH.Feature Gate Issue: #30819