This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add alt_bn128 syscall tests (and fix related issues) #31436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
changed the title
Codecov Report
@@ Coverage Diff @@
## master #31436 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 736 736
Lines 205955 205932 -23
=======================================
+ Hits 168631 168651 +20
+ Misses 37324 37281 -43 |
Lichtso
previously approved these changes
May 22, 2023
|
@CriesofCarrots We need one more approval on this. |
|
@vadorovsky Can you delete the last two commits and rebase? |
Lichtso
previously approved these changes
May 22, 2023
* Fix C headers (the name of the syscall was incorrect).
* Add C SBF tests using the alt_bn128 syscall.
* Fix the Rust SBF program:
* Do not use serde and array-bytes, provide test cases as byte arrays
directly.
* Use the `custom_heap_default` macro.
* Replace `bpf` with `sbf` in the crate name.
* Execute both previously existing Rust tests and new C tests in
`programs/sbf/tests`, so they are actually tested on CI.
|
@Lichtso @CriesofCarrots done, thank you for quick reaction! |
Lichtso
approved these changes
May 22, 2023
|
CI is green, PR is approved. Doing a drive-by merge-assist on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom_heap_defaultmacro.bpfwithsbfin the crate name.programs/sbf/tests, so they are actually tested on CI./cc @Lichtso @ananas-block