This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
StorageStage now sends transactions at the local TPU #3195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
commented
Mar 8, 2019
exit: &Arc<AtomicBool>, | ||
keypair: &Arc<Keypair>, | ||
account_to_create: Option<Pubkey>, | ||
) -> io::Result<()> { | ||
if let Some(leader_info) = cluster_info.read().unwrap().leader_data() { | ||
let mut client = mk_client_with_timeout(leader_info, Duration::from_secs(5)); | ||
let node_info = cluster_info.read().unwrap().my_data(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/leader_data/my_data/
on this line is really the only functional change in this PR.
The rest of the patch is just code shifting around and my desire to purge the codebase of "tx" (like does this mean "transaction" or "transmit"...we use "tx" for both!)
sakridge
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Codecov Report
@@ Coverage Diff @@
## master #3195 +/- ##
========================================
+ Coverage 81.1% 81.2% +<.1%
========================================
Files 129 129
Lines 19614 19614
========================================
+ Hits 15918 15934 +16
+ Misses 3696 3680 -16 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3195 +/- ##
========================================
+ Coverage 81.1% 81.2% +<.1%
========================================
Files 129 129
Lines 19614 19614
========================================
+ Hits 15918 15934 +16
+ Misses 3696 3680 -16 |
Szymongib
pushed a commit
to ChorusOne/solana
that referenced
this pull request
Oct 28, 2024
…t of solana-labs#3194) (solana-labs#3195) rolls back chained Merkle shreds for testnet downgrade (solana-labs#3194) (cherry picked from commit 69916f1) Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local TPU will forward the transactions as needed if it's not currently the leader.
This reduces the complexity of:
cc: #3193