Add test for compaction filter purge #33494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33494 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 802 802
Lines 217779 217835 +56
=========================================
+ Hits 178111 178128 +17
- Misses 39668 39707 +39 |
There was a problem hiding this comment.
LGTM!
Technically, this test only runs on one of the "special" columns; however, I think that is ok since the compaction filter solely relies on being able to extract the slot from the key ... we'd have much bigger problems if we weren't extracting slot from AddressSignatures
| @@ -1287,6 +1287,11 @@ impl Database { | |||
| pub fn live_files_metadata(&self) -> Result<Vec<LiveFile>> { | |||
| self.backend.live_files_metadata() | |||
| } | |||
|
|
|||
| pub fn compact_range_cf<C: Column + ColumnName>(&self, from: &[u8], to: &[u8]) { | |||
There was a problem hiding this comment.
I also exposed compact_range_cf functionality as a method on Database -- I need it for the test, but thought it might be useful for purging the special columns in other contexts. But I could lock it down within mod tests if preferred.
I'm ok leaving this open - after all, it is a layer down after all and not on Blockstore like you said.
Additionally, I had pondered running a compaction on blockstore of warehouse nodes before we load them up to google bucket so this is a nice kick to run that test soon.
* Add Database::compact_range_cf method * Add test of CompactionFilter purge
Problem
I'm exploring removing the primary-index from the Blockstore "special column" keys. But it's difficult to tell if I might be breaking current purge functionality, because there is no test of CompactionFilter-type purge.
Summary of Changes
Add test of compaction-filter purge.
I also exposed
compact_range_cffunctionality as a method onDatabase-- I need it for the test, but thought it might be useful for purging the special columns in other contexts. But I could lock it down withinmod testsif preferred.