This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Make Blockstore::purge_special_columns_exact() bail if columns empty #33534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2023 22:17
The special columns, TransactionStatus and AddressSignatures, are only populated if --enable-rpc-transaction-history is passed. Cleaning these columns for a range of slots is very expensive, as the block for each slot must be read, deserialized, and then parsed to extract all of the transaction signatures and address pubkeys. This change adds a simple check to see if there are any values at all in the special columns. If there are not, then the whole process described above can be skipped for nodes that are not storing the special columns.
steviez
force-pushed
the
bstore_purge_exact_early_bail
branch
from
4431a7c to
2be4a28
Compare
steviez
commented
Oct 5, 2023
| let num_entries = 1; | ||
| let max_slot = 9; | ||
| for slot in 0..=max_slot { | ||
| let entries = make_slot_entries_with_transactions(num_entries); |
There was a problem hiding this comment.
This whole block below of generating entries / shreds / inserting shreds / writing transaction status is duplicated across several functions in both blockstore_purge.rs and blockstore.rs.
However, adding it here in order to avoid any potential merge conflicts with #33419, we can deduplicate stuff later
CriesofCarrots
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #