This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Define register_unique_recent_blockhash_for_test #33880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Oct 26, 2023
Comment on lines
+4188
to
+4189
| // gating this under #[cfg(feature = "dev-context-only-utils")] isn't easy due to | ||
| // solana-program-test's usage... |
There was a problem hiding this comment.
my mind is in firm state not to be derailed for fiddling with my pet subproject (dcou). lol
There was a problem hiding this comment.
naming and comment make the reasoning clear; all good
Codecov Report
@@ Coverage Diff @@
## master #33880 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 809 809
Lines 217824 217827 +3
=======================================
+ Hits 178387 178427 +40
+ Misses 39437 39400 -37 |
apfitzge
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another very small prep pr.
extracted from: #33070