This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Adjust solana-core for cleaner scheduler-pr diff #33881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Oct 26, 2023
| @@ -2786,7 +2786,6 @@ impl ReplayStage { | |||
| match replay_result { | |||
| Ok(replay_tx_count) => tx_count += replay_tx_count, | |||
| Err(err) => { | |||
| // Error means the slot needs to be marked as dead | |||
There was a problem hiding this comment.
kind of redundant comment.
ryoqun
commented
Oct 26, 2023
| @@ -2802,8 +2801,7 @@ impl ReplayStage { | |||
| ancestor_hashes_replay_update_sender, | |||
| purge_repair_slot_counter, | |||
| ); | |||
| // If the bank was corrupted, don't try to run the below logic to check if the | |||
| // bank is completed | |||
| // don't try to run the below logic to check if the bank is completed | |||
There was a problem hiding this comment.
corrupted is kind of ambiguous word. just remove it.
ryoqun
commented
Oct 26, 2023
Comment on lines
+815
to
+820
| let (replay_vote_sender, replay_vote_receiver) = unbounded(); | ||
|
|
||
| // block min prioritization fee cache should be readable by RPC, and writable by validator | ||
| // (by both replay stage and banking stage) | ||
| let prioritization_fee_cache = Arc::new(PrioritizationFeeCache::default()); | ||
|
|
There was a problem hiding this comment.
these two strictly-tx-execution related variables are hoisted here to be used SchedulerPool creation, which must have been completed relatively early in this fn to be ready to use for ProcessBlockStore just below.
Codecov Report
@@ Coverage Diff @@
## master #33881 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 809 809
Lines 217824 217824
=======================================
+ Hits 178387 178421 +34
+ Misses 39437 39403 -34 |
apfitzge
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yet another small prep pr...
extracted from: #33070