This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
[TieredStorage] Add AccountOffset type #33927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33927 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 809 809
Lines 218403 218406 +3
=========================================
- Hits 178910 178906 -4
- Misses 39493 39500 +7 |
yhchiang-sol
force-pushed
the
ts-account-offset
branch
from
8a38f80 to
60735c6
Compare
yhchiang-sol
changed the title
yhchiang-sol
force-pushed
the
ts-account-offset
branch
from
60735c6 to
38442ce
Compare
brooksprumo
reviewed
Nov 4, 2023
brooksprumo
approved these changes
Nov 6, 2023
yhchiang-sol
added a commit
that referenced
this pull request
Nov 9, 2023
#### Problem #33927 introduced a new type AccountOffset, but HotStorageReader still uses `usize` to access accounts. #### Summary of Changes This PR makes HotStorageReader use the new AccountOffset type.
yhchiang-sol
added a commit
to yhchiang-sol/solana
that referenced
this pull request
Feb 13, 2024
…labs#33964) #### Problem solana-labs#33927 introduced a new type AccountOffset, but HotStorageReader still uses `usize` to access accounts. #### Summary of Changes This PR makes HotStorageReader use the new AccountOffset type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TieredStorage conceptually has different offsets. However, the current code directly
uses the same primitive type for accessing offsets, which is error-prone as one could
easily use one offset to access data that should be accessed with a different offset
type.
Summary of Changes
This PR introduces the AccountOffset type, which allows static-check to on different
type of TieredStorage offsets.