-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34017 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 816 817 +1
Lines 219751 219760 +9
=========================================
+ Hits 180027 180033 +6
- Misses 39724 39727 +3 |
Also FYI, when addressing PR feedback and pushing those changes, using force-push often makes it harder for me as a reviewer to re-review and actually see what has changed. There's no exact science, but I do recommend against force-pushing when possible. Also refer to https://github.com/solana-labs/solana/blob/master/CONTRIBUTING.md#is-your-pr-easy-to-say-yes-to. It has some guidance on force-pushing as well. Thanks! |
Thanks for the guidance. I'll keep an eye on that document for further contributions. |
Signed-off-by: Lucas Steuernagel <[email protected]>
Problem
Accounts::load_accounts
is used only inruntime
and needs only two functions fromAccoutnsDb
as a dependency. The code is better suited to the runtime folder.Summary of Changes
I moved
Accounts::load_accounts
and its dependencies toruntime/accounts
.