This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
multinode-demo/fullnode.sh: Add --poll-for-new-genesis-block flag #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Nov 14, 2024
* spl: Bump to newest SPL crates for v2.1 release #### Problem A lot of builds are currently broken due to the incompatibility between v2.0 and v2.1. All of the SPL crates have been bumped to use the Solana v2.1 crates, but it isn't being used in the monorepo. #### Summary of changes Bump the SPL crates to their newest versions, and correctly parse the new token-2022 instructions and account types. The trickiest changes are the confidential transfer / mint / burn instruction parsing, otherwise the changes are straightforward. * Address feedback * Improve parsing logic per discussion * Parse initialize instructions correctly * Add comments for parsing * Improve account labels * Update lockfile from rebase
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Nov 25, 2024
#### Problem The new parsers for the confidential transfer extensions in solana-labs#3431 don't have any tests, which is dangerous because they involve indexing directly into arrays, which can panic at runtime. #### Summary of changes Add tests for all the instructions involving proofs, which have the more complicated parsing logic. Specifically, it's testing to make sure that nothing panics. These tests actually uncovered a bug that triggered a panic for instructions with just barely enough accounts and also the instructions sysvar.
KirillLykov
pushed a commit
to KirillLykov/solana
that referenced
this pull request
Nov 26, 2024
#### Problem The new parsers for the confidential transfer extensions in solana-labs#3431 don't have any tests, which is dangerous because they involve indexing directly into arrays, which can panic at runtime. #### Summary of changes Add tests for all the instructions involving proofs, which have the more complicated parsing logic. Specifically, it's testing to make sure that nothing panics. These tests actually uncovered a bug that triggered a panic for instructions with just barely enough accounts and also the instructions sysvar.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A validator not managed by
net/connected to a testnet has no idea when the testnet ledger is recreated.When then
--poll-for-new-genesis-blockflag is added,fullnode.shdoes exactly that. Every minute it checks if the genesis block from its cluster entrypoint has changed and if so restarts with the new genesis block.