This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Removes glob import of ApplyFeatureActivationsCaller #34334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34334 +/- ##
========================================
Coverage 81.9% 82.0%
========================================
Files 819 819
Lines 220422 220422
========================================
+ Hits 180652 180781 +129
+ Misses 39770 39641 -129 |
HaoranYi
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Well... today I learned about glob imports of enums and how they interact with match statements. Basically, glob imports of an enum that are used with a
matchcan be a footgun. Refer to this playground:https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9f0ce5f074f7b4a71f487ae8c6a1902d
Summary of Changes
Removes glob import of ApplyFeatureActivationsCaller.