This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Metrics prioritization fees #34653
Merged
Metrics prioritization fees #34653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34653 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 827 827
Lines 223884 223980 +96
=========================================
+ Hits 182841 182893 +52
- Misses 41043 41087 +44 |
apfitzge
suggested changes
Jan 4, 2024
tao-stones
reviewed
Jan 8, 2024
apfitzge
reviewed
Jan 9, 2024
core/src/banking_stage/transaction_scheduler/transaction_state_container.rs
Outdated
Show resolved
Hide resolved
apfitzge
reviewed
Jan 9, 2024
core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
Outdated
Show resolved
Hide resolved
apfitzge
reviewed
Jan 11, 2024
core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
Outdated
Show resolved
Hide resolved
core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
Outdated
Show resolved
Hide resolved
apfitzge
reviewed
Jan 11, 2024
core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
Outdated
Show resolved
Hide resolved
apfitzge
suggested changes
Jan 19, 2024
core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
Outdated
Show resolved
Hide resolved
| .filter_map(|transaction| { | ||
| let round_compute_unit_price_enabled = false; // TODO get from working_bank.feature_set | ||
| transaction | ||
| .get_transaction_priority_details(round_compute_unit_price_enabled) |
There was a problem hiding this comment.
this is scanning through all transaction ixs to get the priority. @taozhu-chicago - this is another case motivating the RuntimeTransaction that carries meta 😢
|
@godmodegalactus looks like this needs to be rebased or have master merged in - CI is flagging because of a vulnerability in a dependency. |
Fixed |
apfitzge
approved these changes
Jan 24, 2024
|
Merge ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there are not enough metrics about prioritization fees for each thread processing transactions. We need few more metrics to track how prioritization fees are respected by the validator. As we are on the verge of changing the scheduler metrics like these could be very important.
Summary of Changes
Adding a metrics which tracks min and max prioritization fees in the heap before starting to build the block.
Adding a metrics which tracks min and max prioritization fees for transactions that are scheduled for execution.
Fixes #