This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Removes remaining unused accounts data len bits #34732
Merged
brooksprumo
merged 4 commits into
solana-labs:master
from
brooksprumo:accounts-data-size/remove-misc
Jan 10, 2024
Merged
Removes remaining unused accounts data len bits #34732
brooksprumo
merged 4 commits into
solana-labs:master
from
brooksprumo:accounts-data-size/remove-misc
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54bd175
to
171ceae
Compare
brooksprumo
commented
Jan 10, 2024
/// The change in accounts data len | ||
pub accounts_data_len_delta: i64, | ||
} | ||
pub struct ProcessedMessageInfo {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few options here:
- Change to
pub struct ProcessedMessageInfo;
, without the{}
- Remove the struct entirely
Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 0351a8a
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34732 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222730 222699 -31
=======================================
+ Hits 182293 182339 +46
+ Misses 40437 40360 -77 |
Lichtso
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a few more bits of code related to accounts data meter and accounts data len during transaction processing that are now unused.
Summary of Changes
Each logical change is its own commit: