This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Skip creating reward partition account for --partitioned-epoch-rewards-force-enable-single-slot
#34946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--partitioned-epoch-rewards-force-enable-single-slot
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34946 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 830 830
Lines 224873 224878 +5
=======================================
+ Hits 183615 183635 +20
+ Misses 41258 41243 -15 |
brooksprumo
reviewed
Jan 25, 2024
CriesofCarrots
suggested changes
Jan 25, 2024
brooksprumo
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Probably should wait to merge until Tyera gives a too.
CriesofCarrots
approved these changes
Jan 25, 2024
automerge label removed due to a CI failure |
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Tyera <[email protected]>
automerge label removed due to a CI failure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A follow up PR from #34809
We can run the validator against mainnet with the new partitioned reward code by enabling
--partitioned-epoch-rewards-force-enable-single-slot
CLI argument.Recently, my test node running with the above CLI fails on account hash mismatch. It turns out that the mismatch is coming from the new partition reward account introduced at the epoch, i.e. #34624.
In #34809, we solve this problem by ignoring the PDA accounts for account hash, bank capital and bank hash. This works but it is too hacky. And it turns out that keeping the PDA accounts doesn't provide any other benefit to test the related
getInflactionReward
RPC method.Therefore, we want a simpler fix.
Summary of Changes
--partitioned-epoch-rewards-force-enable-single-slot
Fixes #