This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rename fork selection and locktower to Tower BFT Consensus #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
previously approved these changes
Jun 10, 2019
pgarg66
previously approved these changes
Jun 10, 2019
aeyakovenko
force-pushed
the
fork_selection_to_tower_consensus
branch
from
5c9e4ea to
4fe35a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4598 +/- ##
========================================
- Coverage 78.7% 78.6% -0.2%
========================================
Files 192 192
Lines 34260 34404 +144
========================================
+ Hits 26989 27056 +67
- Misses 7271 7348 +77 |
|
@sagar-solana |
|
No idea. Weird. @danpaul000 ? |
|
I’ve seen that test fail occasionally too. I think we have a number of racy tests again |
|
Seems to fail repeatedly for this PR |
|
It's unable to bind to some crazy high port. Must be rpc or something binding to "any". Is it running on the same CI machine repeated ? @aeyakovenko your PR works just fine on my laptop. Maybe need to rebase because one of the flaky tests is ignored. |
aeyakovenko
force-pushed
the
fork_selection_to_tower_consensus
branch
from
4fe35a8 to
ecec24e
Compare
mergify
bot
dismissed stale reviews from garious and pgarg66
Pull request has been modified.
aeyakovenko
force-pushed
the
fork_selection_to_tower_consensus
branch
from
ecec24e to
0663b7e
Compare
s/locktower/towerbft/g fmt renames rename remove second link metrics format
aeyakovenko
force-pushed
the
fork_selection_to_tower_consensus
branch
from
0663b7e to
234e628
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Name the consensus algo.
Summary of Changes
Rename fork selection and locktower to Tower BFT. Rename locktower to Tower. Make metrics and all the names are consistent.
Fixes #