Remove .env file creation #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjhenry
force-pushed
the
rjh_remove_entrypoint_script
branch
from
1e2dced to
8b233ae
Compare
rjhenry
force-pushed
the
rjh_remove_entrypoint_script
branch
from
3c6aa55 to
92f542d
Compare
stavros-k
reviewed
Jul 6, 2023
docker-entrypoint.sh
Outdated
| fi | ||
| fi | ||
| # Ensure these is no local .env file | ||
| [ -f ".env" ] && rm .env |
There was a problem hiding this comment.
Maybe instead of deleting it, having error out with a log message to something like "please migrate the .env values into your compose or docker run setup"
Just to avoid custom configs being lost.
Or at least my .env .env.bak
There was a problem hiding this comment.
That makes sense - I've adjusted this now.
stavros-k
approved these changes
Jul 7, 2023
|
Is there anything I can help with to complete this? |
rjhenry
force-pushed
the
rjh_remove_entrypoint_script
branch
from
8785db9 to
2bfe6aa
Compare
I've just updated the documentation change to reflect the changed version number, so as long as the automated tests pass I'll be merging this later on today. Thanks for the offer though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.