Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Fix some of vulnerability issue relative python packages #14269

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Mar 16, 2023

Why I did it

Fix some of vulnerability issue relative python packages #14269
Pillow: [CVE-2021-27921]
Wheel: [CVE-2022-40898]
lxml: [CVE-2022-2309]

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@xumia
Copy link
Collaborator Author

xumia commented Mar 17, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia
Copy link
Collaborator Author

xumia commented Mar 19, 2023

Fix Setuptools: [CVE-2022-40897] later, since it has impact on the libyang build.

@xumia xumia enabled auto-merge (squash) March 20, 2023 04:31
@xumia xumia requested a review from StormLiangMS March 20, 2023 04:31
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xumia xumia merged commit 7209666 into sonic-net:master Mar 20, 2023
@xumia xumia deleted the fix-vulner-1 branch March 20, 2023 06:15
@mssonicbld
Copy link
Collaborator

@xumia PR conflicts with 202211 branch

xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 20, 2023
…onic-net#14269)

Why I did it
Fix some of vulnerability issue relative python packages sonic-net#14269
Pillow: [CVE-2021-27921]
Wheel: [CVE-2022-40898]
lxml: [CVE-2022-2309]

How I did it
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 20, 2023
…onic-net#14269)

Why I did it
Fix some of vulnerability issue relative python packages sonic-net#14269
Pillow: [CVE-2021-27921]
Wheel: [CVE-2022-40898]
lxml: [CVE-2022-2309]

How I did it
yxieca pushed a commit that referenced this pull request Mar 20, 2023
…14269) (#14353)

Why I did it
Fix some of vulnerability issue relative python packages #14269
Pillow: [CVE-2021-27921]
Wheel: [CVE-2022-40898]
lxml: [CVE-2022-2309]

How I did it
@xumia
Copy link
Collaborator Author

xumia commented Mar 22, 2023

For 202211: #14352

StormLiangMS pushed a commit that referenced this pull request Mar 22, 2023
…14269) (#14352)

Why I did it
Fix some of vulnerability issue relative python packages #14269
Pillow: [CVE-2021-27921]
Wheel: [CVE-2022-40898]
lxml: [CVE-2022-2309]

How I did it
How to verify it
@k-v1
Copy link
Contributor

k-v1 commented Mar 25, 2023

@xumia FYI

Some utils like safety also report about CVE in certifi package.

-> Vulnerability found in certifi version 2017.4.17
   Vulnerability ID: 52365
   Affected spec: <2022.12.07
   ADVISORY: Certifi 2022.12.07 includes a fix for CVE-2022-23491: Certifi 2022.12.07 removes root certificates from "TrustCor"
   from the root store. These are in the process of being removed from Mozilla's trust store. TrustCor's root certificates are being...
   CVE-2022-23491
   For more information, please visit https://pyup.io/v/52365/f17

This old version is used in mgmt-framework.

@k-v1
Copy link
Contributor

k-v1 commented Apr 26, 2023

@xumia

probably need also to upgrade wheel here:

sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip3 install 'wheel==0.35.1'

RUN pip3 install --no-cache-dir wheel==0.35.1

RUN pip3 install --no-cache-dir wheel==0.35.1

@xumia
Copy link
Collaborator Author

xumia commented Apr 26, 2023

@xumia

probably need also to upgrade wheel here:

sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip3 install 'wheel==0.35.1'

RUN pip3 install --no-cache-dir wheel==0.35.1

RUN pip3 install --no-cache-dir wheel==0.35.1

@k-v1 , yes, we should fix the missing ones, I will send another PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants