Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change static rt expiry timer max value #14397

Merged
merged 2 commits into from
Mar 26, 2023
Merged

change static rt expiry timer max value #14397

merged 2 commits into from
Mar 26, 2023

Conversation

jcaiMR
Copy link
Contributor

@jcaiMR jcaiMR commented Mar 23, 2023

Why I did it

Change static route expiry timer max timeout value from 1800 to 172800.
To keep same value range as defined in sonic-restapi/sonic_api.yaml

How I did it

How to verify it

apply change to bgpcfd, restart bgp container see if the value take action.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@jcaiMR jcaiMR requested a review from StormLiangMS as a code owner March 23, 2023 16:41
@StormLiangMS StormLiangMS requested a review from prsunny March 26, 2023 12:20
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit b3c73f8 into sonic-net:master Mar 26, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Mar 26, 2023
Why I did it
Change static route expiry timer max timeout value from 1800 to 172800.
To keep same value range as defined in sonic-restapi/sonic_api.yaml

How I did it
How to verify it
apply change to bgpcfd, restart bgp container see if the value take action.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #14419

@liuh-80
Copy link
Contributor

liuh-80 commented Apr 19, 2023

202012 branch PR merged: #14497

yxieca pushed a commit that referenced this pull request Apr 19, 2023
Why I did it
Change static route expiry timer max timeout value from 1800 to 172800.
To keep same value range as defined in sonic-restapi/sonic_api.yaml

How I did it
How to verify it
apply change to bgpcfd, restart bgp container see if the value take action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants