-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change static rt expiry timer max value #14397
Merged
StormLiangMS
merged 2 commits into
sonic-net:master
from
jcaiMR:dev/adjust_static_rt_timer_max
Mar 26, 2023
Merged
change static rt expiry timer max value #14397
StormLiangMS
merged 2 commits into
sonic-net:master
from
jcaiMR:dev/adjust_static_rt_timer_max
Mar 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StormLiangMS
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 26, 2023
Why I did it Change static route expiry timer max timeout value from 1800 to 172800. To keep same value range as defined in sonic-restapi/sonic_api.yaml How I did it How to verify it apply change to bgpcfd, restart bgp container see if the value take action.
Cherry-pick PR to 202211: #14419 |
mssonicbld
added a commit
that referenced
this pull request
Mar 26, 2023
8 tasks
202012 branch PR merged: #14497 |
yxieca
pushed a commit
that referenced
this pull request
Apr 19, 2023
Why I did it Change static route expiry timer max timeout value from 1800 to 172800. To keep same value range as defined in sonic-restapi/sonic_api.yaml How I did it How to verify it apply change to bgpcfd, restart bgp container see if the value take action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Change static route expiry timer max timeout value from 1800 to 172800.
To keep same value range as defined in sonic-restapi/sonic_api.yaml
How I did it
How to verify it
apply change to bgpcfd, restart bgp container see if the value take action.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)