Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bgpcfgd] Add dependency callback logic in SRv6 Manager to handle out-of-order table processing #21827

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BYGX-wcr
Copy link
Contributor

@BYGX-wcr BYGX-wcr commented Feb 21, 2025

Why I did it

Previously, if the SRv6 manager received a config update that added a SRV6_MY_SID entry before its corresponding LOCATOR entry added, the SRv6 manager would not process the SRV6_MY_SID entry and print an ERR syslog. However, during testing, NVIDIA team found that it is possible to have such a scenario in normal operations, especially during config reload. So, we decide to add a dependency-based caching mechanism to handle out-of-order table processing.

Fix #21826 (Issue)

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202412

Tested branch (Please provide the tested image version)

  • 202412

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BYGX-wcr BYGX-wcr requested a review from Yakiv-Huryk February 21, 2025 22:22
@BYGX-wcr BYGX-wcr assigned abdosi and unassigned abdosi Feb 21, 2025
@BYGX-wcr BYGX-wcr requested a review from abdosi February 21, 2025 22:22
@BYGX-wcr BYGX-wcr marked this pull request as ready for review February 21, 2025 23:10
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Yakiv-Huryk
Copy link
Contributor

@BYGX-wcr is it possible to add a test for it?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BYGX-wcr
Copy link
Contributor Author

@BYGX-wcr is it possible to add a test for it?

Added. And it has passed in the build checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SRv6: ERR bgp#bgpcfgd: Found a SRv6 SID config entry with a locator that does not exist
5 participants