[MUX/PFCWD] Use in_ports for acls instead of seperate ACL table #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daall
reviewed
Mar 16, 2021
orchagent/muxorch.h
Outdated
| @@ -101,7 +102,7 @@ class MuxCable | |||
| bool stateInitActive(); | |||
| bool stateStandby(); | |||
|
|
|||
| bool aclHandler(sai_object_id_t, bool add = true); | |||
| bool aclHandler(sai_object_id_t, string, bool add = true); | |||
There was a problem hiding this comment.
can we give the rest of the parameters names?
Comment on lines
+741
to
+745
| AclRule* rule = gAclOrch->getAclRule(table_name, rule_name); | ||
| if (rule == nullptr) | ||
| { | ||
| SWSS_LOG_THROW("ACL Rule does not exist for port %s, rule %s", alias_.c_str(), rule_name.c_str()); | ||
| } |
There was a problem hiding this comment.
Are we guaranteed there will always be a rule here? If there's no PFC storm and no switchover then won't we throw an unnecessary exception?
There was a problem hiding this comment.
Yes it is guaranteed; In the constructor, we always create an ACL rule and in this destructor, it would be an exception if we don't find the rule. Same is done for pfwdacl as well, @vmittal-msft,
There was a problem hiding this comment.
AH this is the handler not the orch, I understand now. Thanks!
vmittal-msft
approved these changes
Mar 17, 2021
daall
approved these changes
Mar 17, 2021
daall
pushed a commit
that referenced
this pull request
Mar 19, 2021
*Use ACL_TABLE_DROP for both PFC_WD and MUX *Use MATCH_IN_PORTS instead of binding port to ACL table and program single ACL rule
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…c-net#1670) *Use ACL_TABLE_DROP for both PFC_WD and MUX *Use MATCH_IN_PORTS instead of binding port to ACL table and program single ACL rule
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did HLD for Dump Utility: HLD. Added the COPP Module to the Debug Dump Utility Added the Corresponding UT's
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Implemented vlan and vlan_member modules for debug dump utility. How I did it Used infrastructure and followed examples in sonic-net#1666 sonic-net#1667 sonic-net#1668 sonic-net#1669 sonic-net#1670 How to verify it On switch: dump state vlan <vlan_name> dump state vlan_member '<vlan_name|<member_name>' Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
Optimize ACL TCAM use
How I verified it
Run test on DUT and validated the PBMP
Details if related