Vlan stacking implementation #2372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@venkatmahalingam , please review |
prsunny
reviewed
Jul 9, 2022
| @@ -0,0 +1,199 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
@prabhataravind , please review the test/cleanup
There was a problem hiding this comment.
Test/cleanup Looks good to me!
|
/easycla |
prvattem
reviewed
Aug 25, 2022
| goto vlan_stacking_parse_failed; | ||
| } | ||
|
|
||
| if (s_vlan_priority < 0 || s_vlan_priority > 7) |
There was a problem hiding this comment.
s_vlan_priority is unsigned int. It cant be "< 0". Need to relook at this check?
There was a problem hiding this comment.
no, 0xFF is not valid value
prvattem
reviewed
Aug 25, 2022
| sai_object_id_t port_oid = port.m_type == Port::PHY ? port.m_port_id : port.m_lag_id; | ||
| VlanStackKey stack_key = { port_oid, (uint16_t)to_uint<uint16_t>(s_vlanid) }; | ||
|
|
||
| task_status = deleteVlanStackEntry(stack_key); |
There was a problem hiding this comment.
Why a delete is issued before Adding the Stacking Entry?
There was a problem hiding this comment.
To make modify action easy, so use remove and add to support update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implemented the VLAN stacking.
Why I did it
N/A
How I verified it
Verified using vs tests.
Details if related
No.