[show] Fix for 'trunk' PortChannel reported as 'routed' port #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a PortChannel to a Vlan group, will change the 'Vlan' tag to 'trunk'. Signed-off-by: Shlomi Bitton <[email protected]>
|
retest this please |
1 similar comment
|
retest this please |
prsunny
reviewed
Jul 30, 2020
prsunny
approved these changes
Jul 30, 2020
abdosi
pushed a commit
that referenced
this pull request
Aug 9, 2020
Adding a PortChannel to a Vlan group, will change the 'Vlan' tag to 'trunk'. Signed-off-by: Shlomi Bitton <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
As part of this commit and previous commit ff6cb6c sonic-utilities submodule for 201911 has been updated to take following changes: Add support for QSFP-DD cables on 'show' command (sonic-net#989) [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002) Enable HW watchdog before fast-reboot (sonic-net#977) [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957) (sonic-net#975) [filter-fdb] Fix For Vlan Defined With No CIDR (sonic-net#976) [show/config]: combine feature and container feature cli (sonic-net#1015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton [email protected]
- What I did
Changed the output of 'show interfaces status' field related to a PortChannel.
If the PortChannel is a member of a vlan group it will be printed as 'trunk' port instead of default 'routed'.
- How I did it
Check if the PortChannel is a member of a Vlan group and assign a proper tag for it.
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
PortChannel0005 N/A 100G 9100 N/A N/A routed down up N/A N/A
- New command output (if the output of a command-line utility has changed)
PortChannel0005 N/A 100G 9100 N/A N/A trunk down up N/A N/A