[config] Reduce Calls to SONiC Cfggen #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will remove commit from the other branch. |
jleveque
previously requested changes
Aug 14, 2020
tahmed-dev
force-pushed
the
taahme/qos-reduce-calls-cfggen
branch
from
129fe94 to
c7f2d5c
Compare
Which commit and which branch are you referring to? |
I branched off another branch and so there commit that is not in master nor part of this particular PR. Removed those now. Sorry about this inconvenience. |
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to sonic-cfggen during config-setup when configuring buffer/qos. singed-off-by: Tamer Ahmed <[email protected]>
tahmed-dev
force-pushed
the
taahme/qos-reduce-calls-cfggen
branch
from
c7f2d5c to
c8d6ba5
Compare
|
@tahmed-dev: FYI, "retest default please" will not work. If there is only one test named "default", you must use "retest this please". |
pavel-shirshov
previously approved these changes
Aug 17, 2020
neethajohn
suggested changes
Aug 18, 2020
neethajohn
previously approved these changes
Aug 18, 2020
tahmed-dev
force-pushed
the
taahme/qos-reduce-calls-cfggen
branch
from
5adf6f7 to
b30d9ef
Compare
neethajohn
approved these changes
Aug 18, 2020
pavel-shirshov
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen during config-setup when configuring buffer/qos.
singed-off-by: Tamer Ahmed [email protected]
- What I did
Reduce time required to start config-setup service
- How I did it
Used template batch mode to batch together 4 calls into one call to sonic-cfggen
- How to verify it
flame graph showed gain of ~1.5% sonic-cfggen CPU util.
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A