Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master]Fix import lib issue #1114

Closed
wants to merge 4 commits into from
Closed

[master]Fix import lib issue #1114

wants to merge 4 commits into from

Conversation

tim-rj
Copy link
Contributor

@tim-rj tim-rj commented Sep 14, 2020

- What I did
show interface breakout
- How I did it

show interface breakout

- How to verify it

show interface breakout

- Previous command output (if the output of a command-line utility has changed)

root@sonic:/var/core# show interfaces breakout 
Traceback (most recent call last):
  File "/usr/bin/show", line 12, in <module>
    sys.exit(cli())
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 1114, in invoke
    return Command.invoke(self, ctx)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python2.7/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/show/interfaces/__init__.py", line 118, in breakout
    config_db = ConfigDBConnector()
NameError: global name 'ConfigDBConnector' is not defined

- New command output (if the output of a command-line utility has changed)

No import error, just notify  platform.json not exist.
root@switch2:/usr/lib/python2.7/dist-packages/show/interfaces# show interfaces breakout
[Errno 2] No such file or directory: '/usr/share/sonic/device/x86_64-ruijie_b3010-r0/platform.json'
Aborted!

@tim-rj
Copy link
Contributor Author

tim-rj commented Sep 14, 2020

It is related to issue:sonic-net/sonic-buildimage#5343

@tim-rj
Copy link
Contributor Author

tim-rj commented Sep 25, 2020

Any one can help forward?

@lguohan
Copy link
Contributor

lguohan commented Sep 26, 2020

can you only include the changes needed by the fix?

@tim-rj
Copy link
Contributor Author

tim-rj commented Sep 27, 2020

can you only include the changes needed by the fix?
if only import missing libs(remove added global vars & function), 'show interface breakout' will still fail, do I still need to remove the vars & function? Help confirm, waiting reply .

@tim-rj
Copy link
Contributor Author

tim-rj commented Oct 16, 2020

move to a new PR #1179 for refolk the component and modify as review suggestion, close this one.

@tim-rj tim-rj closed this Oct 16, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
 [portsorch] Enable port-level buffer drop counters (sonic-net#1237)
 [vnet]: Fix double route installation for BITMAP VNET interface (sonic-net#1114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants