Fix Unicode issue in ipaddress for python2 #1627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
What I did
This PR is to address the Unicode issue in
fast-reboot-dump.py
script in201911
.There is another PR that addresses same issue in master image #1164
However,
builtins
package is not available in201911
image.So, I create this PR for 201911 branch to fix the issue in another way.
How I did it
Add a custom method to convert
string
tounicode
.How to verify it
Verified on MSN2700, running
SONiC.20191130.72
.First populate some FDB entry and ARP entry, and then run
fast-reboot-dump.py
script. No exception is raised, and we can confirm fromsyslog
that all entries are dumped.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)