CLI to show 'system ready' message when the system is ready take config commands #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I7ba6fb656513bd2f33571e919b3fa634065e7059
Kalimuthu-Velappan
changed the title
Kalimuthu-Velappan
changed the title
jleveque
suggested changes
Jan 27, 2020
Comment on lines
+11
to
+12
| import logging | ||
| import swsssdk |
There was a problem hiding this comment.
These modules are not used. Remove?
| @@ -1579,5 +1589,134 @@ def del_ntp_server(ctx, ntp_ip_address): | |||
| except SystemExit as e: | |||
| ctx.fail("Restart service ntp-config failed with error {}".format(e)) | |||
|
|
|||
| g_ext_cfg = {} | |||
|
|
|||
| @config.group('export', invoke_without_command=False) | |||
There was a problem hiding this comment.
This 'export' group does not appear to be relevant to the 'system ready' changes as stated in the PR title and description. Can these be removed and a separate PR created for them?
|
I will resubmit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Support for System ready message:
New CLI command to show that the system is ready to handle the config commands.
- How I did it
Added support in the show utilities to read all the core service status and port init status. If both are up, then print a �message that 'system is ready', else 'system is not ready'
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->