Return a emplty list if the content is invalid #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the json loads function raises, the return content is invalid, the function should log the error and return an empty list.
|
Returning an empty list might not always be appropriate. There are some endpoints that return a dict, or a string. Callers of those may not expect the return value to be a list. It might be better to make it raise an error instead. |
If the json loads function raises, the return content is invalid, the function should log the error and return an empty list.
|
Sorry for the delay. I didn't receive any email notification that you'd added a new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the json loads function raises, the return content is invalid,
the function should log the error and return an empty list.