Unify constraints tracking across all solvers #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies and centralizes state-management.
… super-class. This simplifies and unifies formula-management and allows reducing specialized code in sub-classes. Furthermore, this commit simplifies code for generating models and for tracking IDs for unsat-cores or interpolation.
baierd
reviewed
Aug 1, 2023
|
There is also a optimization test and 3 SolverAllSatTests failing for appveyor for some reason. |
|
The failing AppVeyor-tests are strange, because I did not modify any Windows-specific code. |
|
Maybe a fluke? Can you restart them? |
The bug is clearly a bug introduced by a recent commit. It did only show up on Windows, and not on Linux.
We should aim for a consistent exception when accessing a closed Prover. We did throw a NoSuchElementException instead of IllegalStateexception.
We move all code related for non-optimization into the Prover-subclass, to have a clean separation between the normal prover and the optimization prover.. It looks as if stack-handling in the optimization-prover was already broken some time, and it is fixed now.
|
There were some inconsistencies in the Z3 implemention for the optimization-prover. Should be fixed by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.