Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add --num-results/-n to gather #1047

Merged
merged 5 commits into from
Jun 29, 2020
Merged

[MRG] add --num-results/-n to gather #1047

merged 5 commits into from
Jun 29, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jun 26, 2020

Provides -n/--num-results argument to sourmash gather.

Fixes #1042.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Contributor Author

ctb commented Jun 26, 2020

This should be ready for review @erikyoung85 @bluegenes

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1047 into master will increase coverage by 9.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   83.51%   92.55%   +9.04%     
==========================================
  Files          99       74      -25     
  Lines        8880     5590    -3290     
==========================================
- Hits         7416     5174    -2242     
+ Misses       1464      416    -1048     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
sourmash/cli/gather.py 100.00% <100.00%> (ø)
sourmash/commands.py 86.87% <100.00%> (+0.09%) ⬆️
src/core/src/ffi/mod.rs
src/core/src/from.rs
src/core/src/index/linear.rs
src/core/src/wasm.rs
src/core/src/index/sbt/mhbt.rs
src/core/tests/signature.rs
src/core/src/index/bigsi.rs
src/core/src/ffi/signature.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2d259...f04244f. Read the comment docs.

@ctb ctb changed the title add --num-results/-n to gather [MRG] add --num-results/-n to gather Jun 26, 2020
@ctb
Copy link
Contributor Author

ctb commented Jun 27, 2020

updated & ready for review again :)

@ctb ctb requested a review from erikyoung85 June 29, 2020 14:21
@ctb ctb merged commit 40b5c35 into master Jun 29, 2020
@ctb ctb deleted the truncate_gather branch June 29, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow for truncating sourmash gather at the command line
2 participants