Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #1021 with a Makefile fix. #1053

Merged
merged 1 commit into from
Jun 27, 2020
Merged

Update #1021 with a Makefile fix. #1053

merged 1 commit into from
Jun 27, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jun 27, 2020

Adds .PHONY to the 'doc' target so as to force a docs build attempt.

This is a PR into #1021.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb mentioned this pull request Jun 27, 2020
6 tasks
@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #1053 into master will increase coverage by 9.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
+ Coverage   83.30%   92.42%   +9.12%     
==========================================
  Files          97       72      -25     
  Lines        8749     5454    -3295     
==========================================
- Hits         7288     5041    -2247     
+ Misses       1461      413    -1048     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
src/core/src/ffi/mod.rs
src/core/src/index/bigsi.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/wasm.rs
src/core/tests/test.rs
src/core/tests/minhash.rs
src/core/src/sketch/ukhs.rs
src/core/src/index/storage.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/from.rs
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2b168...f9177b9. Read the comment docs.

@luizirber luizirber changed the base branch from master to doc_myst June 27, 2020 16:39
@luizirber luizirber merged commit ada128e into doc_myst Jun 27, 2020
@luizirber luizirber deleted the doc_myst_update branch June 27, 2020 16:39
luizirber added a commit that referenced this pull request Jun 27, 2020
* replace recommonmark with myst
* convert index
* fix links with html extensions
* fix headings for sphinx
* fix tests on py27, add docs check in travis
* add docs to toctrees
* warnings are errors in sphinx
* fix make doc (#1053)
Co-authored-by: C. Titus Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants