Use safe_load when using Psych >=3.1 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
commented
Jun 7, 2021
lib/http/cookie_jar/yaml_saver.rb
Outdated
|
|
||
| if YAML.name == 'Psych' && Psych::VERSION >= '3.1' | ||
| def load_yaml(yaml) | ||
| YAML.safe_load(yaml, :permitted_classes => %w[Time HTTP::Cookie Mechanize::Cookie]) |
There was a problem hiding this comment.
psych >=3.1 supports keyword arguments. We still support ruby 1.8.7, hence the rocket syntax.
| @@ -73,4 +73,14 @@ def load(io, jar) | |||
| def default_options | |||
| {} | |||
| end | |||
|
|
|||
| if YAML.name == 'Psych' && Psych::VERSION >= '3.1' | |||
There was a problem hiding this comment.
"3.10" > "3.1", in case you wonder.
There was a problem hiding this comment.
I am so very late here (thanks for doing this update btw), but in the distant future "10.0" < "3.1" :)
…le occurrences of an object
|
Just pushed v1.0.4. |
4 tasks
flavorjones
added a commit
to sparklemotion/mechanize
that referenced
this pull request
Jan 17, 2022
flavorjones
added a commit
to sparklemotion/mechanize
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there are use cases where an untrusted YAML jar should be loaded, but it is a good practice to be explicit about which classes are expected to be serialized in the YAML jar format.
Because CI for 1.8.7/REE was broken, I ran the test suite manually in my local environment with ruby 1.8.7.
This fixes #33.