Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sheet): migration to signals #423

Closed
2 tasks
thatsamsonkid opened this issue Nov 7, 2024 · 1 comment · Fixed by #599
Closed
2 tasks

refactor(sheet): migration to signals #423

thatsamsonkid opened this issue Nov 7, 2024 · 1 comment · Fixed by #599
Assignees
@elite-benni
Labels
enhancement New feature or request
Milestone
Decorator migrati...

Comments

@thatsamsonkid
Copy link
Collaborator

Which scope/s are relevant/related to the feature request?

sheet

Information

Migrate away from all Input/Output and View Decorators

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@thatsamsonkid thatsamsonkid added the enhancement New feature or request label Nov 7, 2024
@ajitzero
Copy link
Contributor

ajitzero commented Nov 7, 2024

Sheet depends on Dialog, so this should be picked up after or along with #427

MerlinMoos added a commit to MerlinMoos/spartan that referenced this issue Dec 2, 2024
@MerlinMoos
refactor(dialog,sheet,popover): migrate to signals spartan-ng#427 spa…
b53cd61 
…rtan-ng#423 spartan-ng#425
@MerlinMoos MerlinMoos mentioned this issue Dec 2, 2024
Closed
57 tasks
elite-benni pushed a commit to elite-benni/spartan that referenced this issue Feb 8, 2025
@MerlinMoos @elite-benni
refactor(dialog,sheet,popover): migrate to signals spartan-ng#427 spa…
ed5250b 
…rtan-ng#423 spartan-ng#425
elite-benni pushed a commit to elite-benni/spartan that referenced this issue Feb 12, 2025
@MerlinMoos @elite-benni
refactor(dialog,sheet,popover): migrate to signals spartan-ng#427 spa…
4005b60 
…rtan-ng#423 spartan-ng#425
@elite-benni elite-benni mentioned this issue Feb 16, 2025
Merged
57 tasks
@elite-benni elite-benni self-assigned this Feb 16, 2025
@github-project-automation github-project-automation bot moved this from PR Open to Done in Spartan UI V1 Roadmap Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elite-benni elite-benni

Labels
enhancement New feature or request
Projects
Spartan UI V1 Roadmap
Status: Done
Milestone
Decorator migration to Signals
Development

Successfully merging a pull request may close this issue.

refactor(dialog,sheet,popover): migrate to signals elite-benni/spartan
3 participants
@ajitzero @thatsamsonkid @elite-benni