Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(repo): add tailwind configuration troubleshooting #601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlexHladin
Copy link

@AlexHladin AlexHladin commented Feb 17, 2025

Hey, my goal with this PR is to improve the project's installation experience.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I've created a new Angular project from scratch and without googling it was super hard to run the project with proper tailwind configuration, but with this documentation improvement a lot of hours could be saved.

@AlexHladin AlexHladin force-pushed the docs/installation-page branch from 0645f65 to d2c25b7 Compare February 17, 2025 16:25
@AlexHladin AlexHladin changed the title docs(installation): add tailwind configuration troubleshooting docs(repo): add tailwind configuration troubleshooting Feb 17, 2025
@AlexHladin AlexHladin force-pushed the docs/installation-page branch from d2c25b7 to e051f99 Compare February 18, 2025 11:17
Copy link
Collaborator

@elite-benni elite-benni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for your contribution.

I think this is not spartan troubleshooting, it is tailwind troubleshooting.

Having tailwind up and running is part of the prerequisites.

Additionally the fix is just for tailwind 3.
Tailwind 4 needs a different setup.

https://tailwindcss.com/docs/installation/framework-guides/angular

Maybe we can refer to the prerequisites instead?

@AlexHladin
Copy link
Author

Hi thanks for your contribution.

I think this is not spartan troubleshooting, it is tailwind troubleshooting.

Having tailwind up and running is part of the prerequisites.

Additionally the fix is just for tailwind 3. Tailwind 4 needs a different setup.

https://tailwindcss.com/docs/installation/framework-guides/angular

Maybe we can refer to the prerequisites instead?

Good point. I've updated the PR.

@AlexHladin AlexHladin force-pushed the docs/installation-page branch from ef987fd to 7f8f193 Compare February 20, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants