Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kayenta): Add svg name to dataSource #486

Merged
merged 2 commits into from
Apr 3, 2020
Merged

feat(kayenta): Add svg name to dataSource #486

merged 2 commits into from
Apr 3, 2020

Conversation

caseyhebebrand
Copy link
Contributor

Depends on spinnaker/deck#8120 merge and then bumping @spinnaker/core.

Given the svg icon loader (#8056) and the upcoming Nav restructure, it is a good time to migrate the nav bar icons to svgs.

In order to do this, the ApplicationDataSource type now has an iconSvg attribute. Once this change propagates to all data sources in deck and deck-kayenta, a follow-up PR will update the NavIcon component to utilize dataSource.iconSvg instead of the current dataSource.icon, which points to the font awesome icon.

christopherthielen
christopherthielen approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@christopherthielen christopherthielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️the switch from iconSvg to iconName

@caseyhebebrand caseyhebebrand changed the title [Do not merge] feat(kayenta): Add svg name to dataSource feat(kayenta): Add svg name to dataSource Apr 3, 2020
@caseyhebebrand caseyhebebrand merged commit 2665ac9 into master Apr 3, 2020
@caseyhebebrand caseyhebebrand deleted the icon-svg branch April 3, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikmunson erikmunson erikmunson approved these changes

@christopherthielen christopherthielen christopherthielen approved these changes

@alanmquach alanmquach Awaiting requested review from alanmquach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caseyhebebrand @erikmunson @christopherthielen